FIX: [okx] fix trade id #1530
Merged
FIX: [okx] fix trade id #1530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bailantaotao
requested review from
c9s,
ycdesu,
kbearXD,
gx578007 and
narumiruna
|
Welcome back! @bailantaotao, This pull request may get 238 BBG. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1530 +/- ##
==========================================
- Coverage 21.78% 21.77% -0.02%
==========================================
Files 606 606
Lines 43931 43941 +10
==========================================
- Hits 9569 9566 -3
- Misses 33680 33693 +13
Partials 682 682
Continue to review full report in Codecov by Sentry.
|
c9s
approved these changes
Feb 7, 2024
ycdesu
approved these changes
Feb 15, 2024
c9s
approved these changes
Feb 15, 2024
|
Hi @bailantaotao, Well done! 248 BBG has been sent to your polygon wallet. Please check the following tx: https://polygonscan.com/tx/0xe763bfe4dd0b93e141b3d377096e0dd6e47040804580a6a8d43c7736f455518c Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past, I used the bill ID as the trade ID because OKX only supports querying trades by bill ID. However, the bill ID is not supported on websocket events.
I updated the implementation, handling the bill ID as a filter in the loop instead of getting the ID from outside, even if you use batch.query.